Skip to content

Conversation

@lionelkusch
Copy link
Collaborator

@lionelkusch lionelkusch commented Sep 11, 2025

Add the tests for CFI.
This PR is based on PR 372 .

@lionelkusch lionelkusch added test Question link to tests API 2 Refactoring following the second version of API labels Sep 11, 2025
@codecov
Copy link

codecov bot commented Sep 11, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 98.19%. Comparing base (d159dca) to head (804cab1).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #393      +/-   ##
==========================================
+ Coverage   98.10%   98.19%   +0.09%     
==========================================
  Files          22       22              
  Lines        1159     1222      +63     
==========================================
+ Hits         1137     1200      +63     
  Misses         22       22              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@lionelkusch
Copy link
Collaborator Author

If we could have a regression test showing that a regular ttest tend to over-estimate pvalues / make false discoveries and that we solve that with NB ttest, that would be a plus.

Originally posted by @jpaillard in #460 (review)

@bthirion
Copy link
Collaborator

If we could have a regression test showing that a regular ttest tend to over-estimate pvalues / make false discoveries and that we solve that with NB ttest, that would be a plus.

Originally posted by @jpaillard in #460 (review)

Why do you want this @jpaillard ? This is a mathematical fact, not particularly tied to what we do in hidimstat ...

@jpaillard
Copy link
Collaborator

Ah, that doesn't go in regression, I see. My bad.

@lionelkusch lionelkusch mentioned this pull request Oct 27, 2025
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

API 2 Refactoring following the second version of API test Question link to tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants