-
Notifications
You must be signed in to change notification settings - Fork 12
API2: (2/4:test) CFI #393
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
API2: (2/4:test) CFI #393
Conversation
Co-authored-by: Joseph Paillard <[email protected]>
Co-authored-by: bthirion <[email protected]>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #393 +/- ##
==========================================
+ Coverage 98.10% 98.19% +0.09%
==========================================
Files 22 22
Lines 1159 1222 +63
==========================================
+ Hits 1137 1200 +63
Misses 22 22 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
If we could have a regression test showing that a regular ttest tend to over-estimate pvalues / make false discoveries and that we solve that with NB ttest, that would be a plus. Originally posted by @jpaillard in #460 (review) |
Why do you want this @jpaillard ? This is a mathematical fact, not particularly tied to what we do in hidimstat ... |
|
Ah, that doesn't go in regression, I see. My bad. |
Add the tests for CFI.
.
This PR is based on PR